Merged
Conversation
rush-skills
approved these changes
Jul 19, 2022
Member
rush-skills
left a comment
There was a problem hiding this comment.
Good work!
I had a question wrt DB changes - will all existing st2exporter-related DB entries (marker, etc.) be automatically purged with these changes? Or is that something we make st2garbagecollector handle?
Member
Author
|
@rush-skills Good call. I added a migration util that can drop the marker collections. |
arm4b
approved these changes
Jul 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed st2exporter service. It is unmaintained and does not get installed. It was originally meant to help with analytics by exporting executions as json files that could be imported into something like elasticsearch. Our code is now instrumented to make a wider variety of stats available to metrics drivers.
Requires StackStorm/st2-packages#723
Closes #5295
Closes StackStorm/st2-packages#367