Skip to content

Fix issue with pack option not working when running policy list cli#5534

Merged
arm4b merged 2 commits intoStackStorm:masterfrom
momokuri-3:bug_fix_policy_cli
Jan 28, 2022
Merged

Fix issue with pack option not working when running policy list cli#5534
arm4b merged 2 commits intoStackStorm:masterfrom
momokuri-3:bug_fix_policy_cli

Conversation

@momokuri-3
Copy link
Contributor

@momokuri-3 momokuri-3 commented Jan 12, 2022

This error occurs when run policy list with st2-client.
If the --pack option is given, it should return only the resources belonging to the provided pack.
However, there was no change in the output when the --pack option was specified or not.

Don't specify the pack option

st2 policy list

+---------------------------------+---------------------+-------------------------+---------+
| ref                             | resource_ref        | policy_type             | enabled |
+---------------------------------+---------------------+-------------------------+---------+
| testpack1.test.concurrency      | testpack1.test      | action.concurrency      | True    |
| testpack2.test.concurrency      | testpack2.test      | action.concurrency      | True    |
+---------------------------------+---------------------+-------------------------+---------+

Specify the pack option

st2 policy list --pack testpack1

+---------------------------------+---------------------+-------------------------+---------+
| ref                             | resource_ref        | policy_type             | enabled |
+---------------------------------+---------------------+-------------------------+---------+
| testpack1.test.concurrency      | testpack1.test      | action.concurrency      | True    |
| testpack2.test.concurrency      | testpack2.test      | action.concurrency      | True    |
+---------------------------------+---------------------+-------------------------+---------+

The code for the case where the pack option was specified was missing, so it will be corrected.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jan 12, 2022
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@arm4b arm4b added the bug fix label Jan 12, 2022
arm4b
arm4b suggested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, - it's a good find!

Could you please include a Unit test case for this bug?
We'll also need a Changelog update.

@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Jan 27, 2022
@momokuri-3 momokuri-3 force-pushed the bug_fix_policy_cli branch 3 times, most recently from 2b9a331 to 108ee69 Compare January 28, 2022 08:15
@arm4b arm4b added this to the 3.7.0 milestone Jan 28, 2022
arm4b
arm4b approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution! 👍

@arm4b arm4b merged commit e90544b into StackStorm:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix CLI policies size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@momokuri-3 @CLAassistant @arm4b