core.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_name (backwards compatible)#5383
Merged
cognifloyd merged 13 commits intomasterfrom Oct 25, 2021
Conversation
…ame collisions noted in issue #4641.
core.inject_trigger: resolve trigger payload shadowing by renaming trigger param
core.inject_trigger: resolve trigger payload shadowing by renaming trigger paramcore.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_param
core.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_paramcore.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_name
core.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_namecore.inject_trigger: resolve trigger payload shadowing by renaming trigger param to trigger_name (backwards compatible)
winem
reviewed
Oct 17, 2021
Co-authored-by: Marcel Weinberg <mweinberg-os@email.de>
cognifloyd
commented
Oct 18, 2021
winem
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges master into the code from #5335, and adds the changelog entry.
Closes #4641
Closes #5335