Skip to content

Remove st2-debug-info#5103

Merged
amanda11 merged 5 commits intomasterfrom
remove_debug_info
Dec 21, 2020
Merged

Remove st2-debug-info#5103
amanda11 merged 5 commits intomasterfrom
remove_debug_info

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Dec 8, 2020

Remove st2debug component, as it was only used for submit-debug-info tool

This was referenced Dec 10, 2020
Merged
Merged
Merged
@amanda11
Copy link
Contributor Author

amanda11 commented Dec 10, 2020

Associated PRs would need merging first before checks fail. But should probably review this PR first to ensure agree to remove the st2debug component, and then if agreed to then review the linked PRs referenced above.

@amanda11 amanda11 changed the title [WIP] Remove st2-debug-info Remove st2-debug-info Dec 10, 2020
@amanda11 amanda11 requested a review from arm4b December 11, 2020 13:01
@amanda11
Copy link
Contributor Author

amanda11 commented Dec 11, 2020

@armab Adding you as a reviewer as you reviewed the associated other PRs, but will wait until this one is approved before I start merging them - just to be 100% sure..

@arm4b arm4b added the refactor label Dec 14, 2020
@amanda11 amanda11 added this to the 3.4.0 milestone Dec 14, 2020
@amanda11 amanda11 requested a review from a team December 20, 2020 21:28
@arm4b
Copy link
Member

arm4b commented Dec 21, 2020 •
edited
Loading

Can you please resolve the git conflicts for this PR?
That'll also restart the CI which would hopefully go green after StackStorm/st2-packages#680.

@arm4b
Copy link
Member

arm4b commented Dec 21, 2020

Following the TravisCI https://travis-ci.org/github/StackStorm/st2/jobs/750849455#L1775 error, this change might need a make .requirements update.

arm4b
arm4b approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for removing that legacy! 👍

@amanda11 amanda11 merged commit 0e8ae75 into master Dec 21, 2020
@amanda11 amanda11 deleted the remove_debug_info branch December 21, 2020 20:23
@cognifloyd cognifloyd mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amanda11 @arm4b