Skip to content

remove obsolete check-licence#5092

Merged
arm4b merged 1 commit intoStackStorm:masterfrom
kroustou:5088_remove_check_licence
Nov 27, 2020
Merged

remove obsolete check-licence#5092
arm4b merged 1 commit intoStackStorm:masterfrom
kroustou:5088_remove_check_licence

Conversation

@kroustou
Copy link
Contributor

@kroustou kroustou commented Nov 26, 2020 •
edited by arm4b
Loading

Closes #5088

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Nov 26, 2020
arm4b
arm4b suggested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That's a good start 👍

There's also an actual file which needs a removal: https://github.com/StackStorm/st2/blob/master/st2common/bin/st2-check-license

Besides of that, please also include the Changelog record (see CHANGELOG.rst) for this PR.

@arm4b
Copy link
Member

arm4b commented Nov 26, 2020

Packages CI build fails (https://circleci.com/gh/StackStorm/st2/11926) as it expects st2-check-license to be present when trying to build the deb/rpm packages here: https://github.com/search?q=org%3AStackStorm+st2-check-license&type=code

Would you provide a PR in https://github.com/stackstorm/st2-packages to remove those instructions too?

@arm4b arm4b added this to the 3.4.0 milestone Nov 26, 2020
@kroustou kroustou force-pushed the 5088_remove_check_licence branch from b784e35 to e697e80 Compare November 26, 2020 13:52
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Nov 26, 2020
@kroustou kroustou force-pushed the 5088_remove_check_licence branch from e697e80 to 0125fc5 Compare November 26, 2020 13:55
arm4b
arm4b suggested changes Nov 26, 2020
View reviewed changes
@kroustou kroustou force-pushed the 5088_remove_check_licence branch from c221bc4 to 4584931 Compare November 26, 2020 17:33
arm4b
arm4b approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Thanks for the help removing legacy from stackstorm! 👍

@arm4b arm4b merged commit e5131b8 into StackStorm:master Nov 27, 2020
@amanda11 amanda11 mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement refactor size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

Remove obsolete 'bin/st2-check-license'

3 participants

@kroustou @CLAassistant @arm4b