ticket #5078 fix: Resolves issue where st2stream crashes with a max depth error when connecting to a mongodb via SSL#5091
Conversation
|
|
arm4b
suggested changes
Nov 24, 2020
Member
arm4b
left a comment
There was a problem hiding this comment.
Thanks for the PR! 👍
Can you please provide a Changelog for this fix so we'll be able to merge it?
Please also compose the PR Title/Description so it'll be more clear what this Pull Request does and why.
arm4b
suggested changes
Nov 25, 2020
CHANGELOG.rst
Outdated
|
|
||
| Fixed | ||
| ~~~~~~~~~ | ||
| * Added monkey patch fix to st2stream to enable it to work with mongodb via SSL. |
Member
There was a problem hiding this comment.
Please follow the Changelog format including the PR number and type of the change if it's (bug fix) (enhancement), etc. See other examples below.
You're also welcome to include your Name or github Username as a contributor credit.
punkrokk
suggested changes
Nov 26, 2020
Member
punkrokk
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good just needs change log syntax updated.
CHANGELOG.rst
Outdated
|
|
||
| Fixed | ||
| ~~~~~~~~~ | ||
| * Added monkey patch fix to st2stream to enable it to work with mongodb via SSL. #5078 #5091 |
Member
There was a problem hiding this comment.
Can you add the (bug fix) part here to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5078