Skip to content

Fix for issue 4998 - Web Hook Rules check http headers in case sensitive manner#5038

Merged
arm4b merged 11 commits intoStackStorm:masterfrom
Rand01ph:fix_4998
Jan 28, 2022
Merged

Fix for issue 4998 - Web Hook Rules check http headers in case sensitive manner#5038
arm4b merged 11 commits intoStackStorm:masterfrom
Rand01ph:fix_4998

Conversation

@Rand01ph
Copy link
Contributor

@Rand01ph Rand01ph commented Sep 10, 2020 •
edited by arm4b
Loading

I have add a payload['headers_lower'] for webhook and add a unittest for this.
Fixes #4998

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Sep 10, 2020
@arm4b arm4b mentioned this pull request Sep 10, 2020
Closed
@stale
Copy link

stale bot commented Dec 12, 2020

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

@stale stale bot added the stale label Dec 12, 2020
@cognifloyd
Copy link
Member

cognifloyd commented Mar 7, 2021

FYI: we just merged a change that reformats all the code with black. Please rebase on master (or merge master into your branch) and reformat your code with black as well. You can use pre-commit install to have black run on your commits. Thanks!

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stale stale bot removed the stale label Sep 6, 2021
cognifloyd
cognifloyd requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rand01ph could you please sign the CLA? (If you signed it before, you'll need to resign it now that it says "Linux Foundation" instead of one of the previous StackStorm stewards).

Also, I just resolved the conflicts, merged master into your branch, and reformatted with black.

I have one style suggestion.

I would like to merge your PR fairly quickly if you can help me at least with the CLA. Hopefully there's not much left before we can merge this.

@cognifloyd cognifloyd added API status:needs cla A manual tag to note PRs that are otherwise ready, but the CLA bot says the CLA has not been signed. labels Oct 5, 2021
Rand01ph and others added 2 commits October 7, 2021 23:35
@cognifloyd cognifloyd removed the status:needs cla A manual tag to note PRs that are otherwise ready, but the CLA bot says the CLA has not been signed. label Oct 7, 2021
@cognifloyd cognifloyd enabled auto-merge October 7, 2021 16:17
@cognifloyd cognifloyd disabled auto-merge October 7, 2021 16:19
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Oct 7, 2021
@cognifloyd cognifloyd added this to the 3.7.0 milestone Oct 7, 2021
@arm4b arm4b added the bug fix label Jan 28, 2022
@arm4b arm4b merged commit d333638 into StackStorm:master Jan 28, 2022
@arm4b
Copy link
Member

arm4b commented Jan 28, 2022 •
edited
Loading

Merged! Thanks, everyone! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

Assignees

No one assigned

Labels

API bug fix enhancement size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

Web Hook Rules check http headers in case sensitive manner

4 participants

@Rand01ph @cognifloyd @CLAassistant @arm4b