Use upstream codecov instead of our own fork#5002
Merged
Conversation
Member
|
Just restarted the failed job |
arm4b
reviewed
Jul 23, 2020
Co-authored-by: Eugen C. <stackstorm@armab.io>
arm4b
approved these changes
Jul 23, 2020
Member
arm4b
left a comment
There was a problem hiding this comment.
Thanks for digging in deeper trying to fix the Codecov issues in st2 CI 👍
punkrokk
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing repeated build failures for codecov issues: https://travis-ci.org/github/StackStorm/st2/jobs/710376520#L27406
The fix is to upgrade to
codecov-python >= 2.1per https://community.codecov.io/t/http-400-while-uploading-to-s3-with-python-codecov-from-travis/1428/6However, we are maintaining our own fork of
codecov-pythonand those changes haven't been merged into our fork.Couple things here:
Until we get the changes merged upstream, i've also submitted a PR against our own
codecov-pythonfork to pull in the upstream changes so our tests can pass again without these errors: StackStorm/codecov-python#2DECISION POINTS / OPTIONS
codecovfailure, we can merge this PR and just use upstream