Fix bytes -> str handling in linux.dig action#4993
Conversation
5ded004 to
df6ae6a
Compare
nmaludy
left a comment
There was a problem hiding this comment.
Only thing i think you could improve upon is to add a test case where a byte string is actually returned from subprocess.
Co-authored-by: Eugen C. <stackstorm@armab.io>
…to fix-dig-action
nmaludy
left a comment
There was a problem hiding this comment.
Love it! This is something we've needed for a while
|
For the Same story for the I’m a little confused why the For the service action, it’s a
Set the For If you need help standing up a test environment to begin with, I would dig through the Travis config and rerun the same commands in a VM. |
The
linux.digaction Python script didn't work on Python 3 due to bytes/string encoding issues. This PR fixes that.TODO: