Conversation
Contributor
Author
|
Since this is a backwards-incompatible change, I would recommend against merging this into ST2 |
punkrokk
approved these changes
Jul 15, 2020
arm4b
reviewed
Jul 16, 2020
arm4b
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1785 introduced a typo in the
st2.action.file_writentrigger name that has gone apparently unnoticed for five years.This PR simply fixes the typo.
Please note that this is not reverse compatible, and so it should be noted in the upgrade documentation. However, the fact that this hasn't ever been reported or fixed would seem to indicate that not many people use this trigger, so hopefully the impact is minimal.
A companion PR for st2docs is incoming.