Fix empty with items list resulting in parent workflow stuck in running#4959
Merged
Fix empty with items list resulting in parent workflow stuck in running#4959
Conversation
Fix a bug where passing an empty list to a with items task in a subworkflow causes the parent workflow to be stuck in running status. The workflow engine usually skips execution of the with items task because the list is empty. The issue here is that when the task is marked complete, the status change in the task wasn't published which will triggered additional logic to handle completion and move the parent workflow forward. This patch publishes the completeion status of the task now.
winem
approved these changes
May 24, 2020
nmaludy
approved these changes
May 24, 2020
Member
nmaludy
left a comment
There was a problem hiding this comment.
Looks good and the tests should help cover this from occurring in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where passing an empty list to a with items task in a subworkflow causes the parent workflow to be stuck in running status. The workflow engine usually skips execution of the with items task because the list is empty. The issue here is that when the task is marked complete, the status change in the task wasn't published which will triggered additional logic to handle completion and move the parent workflow forward. This patch publishes the completeion status of the task now. Fixes #4954.