#4932 - Fixes for field escaping in orquesta workflows#4933
Merged
nmaludy merged 8 commits intoStackStorm:masterfrom May 5, 2020
Merged
#4932 - Fixes for field escaping in orquesta workflows#4933nmaludy merged 8 commits intoStackStorm:masterfrom
nmaludy merged 8 commits intoStackStorm:masterfrom
Conversation
…sta-field-escaping
Contributor
Member
Author
|
FYI build failures were caused by poisoned Travis cache where |
blag
approved these changes
May 4, 2020
arm4b
suggested changes
May 4, 2020
Member
arm4b
left a comment
There was a problem hiding this comment.
This PR definitely needs a Changelog describing the bugfix.
Member
Author
|
@armab Added a changelog. Thank you for noticing this, i was in such a rush to get it fixed i forgot! |
Closed
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #4932
This is a fix for the bug found in #4932 .
I had to revert 3x fields in the workflow DB model:
WorkflowExecutionDB.specfor any fields/dict keys that were statically defined in the workflow spec that include a.in their name:Example:
WorkflowExecutionDB.contextfor any dicts/objects that is present in the "context", ie. from a published variable. This can occur, for example, when runningcore.remote. The resulting dictionary has hostnames/IPs as keys in the returned dict.Example:
TaskExecutionDB.task_specfor any inputs passed into the task that may have a dict with a key contain a..Example:
I've added a single integration test case
examples.orequest-test-field-escapingthat invokes these three corner cases.