#4795 fix 'core.sendmail' for subject line wrapping#4829
#4795 fix 'core.sendmail' for subject line wrapping#4829arm4b merged 3 commits intoStackStorm:masterfrom
Conversation
…e to avoid line wrapping Credit to @guzzijones for finding the fix here https://superuser.com/questions/1225134/why-does-the-base64-of-a-string-contain-n
|
|
arm4b
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Please add a changelog record for this fix in https://github.com/StackStorm/st2/blob/master/CHANGELOG.rst
Additionally, would be good to bump patch version of the core pack to 1.0.1 (https://github.com/StackStorm/st2/blob/master/contrib/core/pack.yaml).
CHANGELOG.rst
Outdated
| * Update ``st2 execution get`` command to always include ``context.user``, ``start_timestamp`` and | ||
| ``end_timestamp`` attributes. (improvement) #4739 | ||
|
|
||
| Contributed by @stevemuskiewicz and @guzzijones |
There was a problem hiding this comment.
This line needs to be moved not before, but after the actual changelog record to be part of the same block.
See how it looks like https://github.com/StackStorm/st2/blob/0fffbdf00cf4d547d254bb4319d6bb5fcb42e976/CHANGELOG.rst#fixed rendered.
There was a problem hiding this comment.
Wups, sorry about that. I'll fix
arm4b
left a comment
There was a problem hiding this comment.
👍
Looks good, thanks for contribution!
Fixes #4795: add
-w 0to base64 encoding of subject line to avoid line wrappingCredit to @guzzijones for finding the fix here https://superuser.com/questions/1225134/why-does-the-base64-of-a-string-contain-n