Update various Python dependencies to latest stable versions#4767
Merged
Update various Python dependencies to latest stable versions#4767
Conversation
Member
Author
|
There seems to be regression in the latest version of pymongo and mongoengine (and potentially combination of both) related to unicode keys which causes test failure :/ I need to dig in and look into a fix. |
Member
Author
|
It turns out the issue is indeed related to pymongo and mongoengine - MongoEngine/mongoengine#2147 I wasted quite a lot of time tracking it down (since it depends on Python version and default encoding used by Python). In the mean time, I will revert |
arm4b
reviewed
Aug 16, 2019
CHANGELOG.rst
Outdated
| (improvement) #4743 | ||
| * Implement "continue" engine command to orquesta workflow. (improvement) #4740 | ||
| * Update various internal dependencies to latest stable versions (apscheduler, eventlet, | ||
| kombu, amqp, pyyaml, mongoengine, python-gnupg, paramiko, tooz, webob, bcrypt). #4767 |
Member
There was a problem hiding this comment.
Makes sense to include a small note that mongo upgrade led to perf improvements, considering you've tested it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates various dependencies to latest stable versions.
I went over the changeslogs and changed things mostly include bug fixes and small improvements.
mongoengine v0.18.x includes change / performance improvement which should be of a particular interest to us - MongoEngine/mongoengine#2049.
I tested / verified it locally and confirmed it increases "save" performance for very large objects (that's very large executions in our case). It's not really drastic, but around 5-30% performance increase depending on the execution size.
It's not as fast as directly inserting execution into database using pymongo and avoiding mongoengine layer all together (something we discussed in the past), but it comes mostly "for free".