Set content-length to 0 in logging messages when return value is a Generator#4723
Merged
arm4b merged 5 commits intoStackStorm:masterfrom Jul 11, 2019
Merged
Conversation
Member
|
Thanks for the contribution. It looks like this |
Member
|
@Kami It would be great to get this merged. I'm having fluentd logging errors due to this. |
arm4b
approved these changes
Jul 11, 2019
Member
arm4b
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
LGTM
I assume it's another +1 considering Tomaz already reviewed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4722
Sets the
content_lengthfield to0instead ofInfinityso that logging messages output proper JSON.