Merged
Conversation
… to native .iso method Reverts StackStorm#49
amanda11
reviewed
Jun 8, 2021
amanda11
left a comment
There was a problem hiding this comment.
Don't feel know enough on repo to give +1, but some feedback.
I'm not sure if some of the files in scripts need updating, eg
- scripts/welcome.sh still refers to U16
- should post-cleanup be cleaning up redis?
Member
Author
|
@amanda11 These are very good finds I missed, thanks a lot for that! 👍 Fixed now. |
amanda11
approved these changes
Jun 9, 2021
amanda11
left a comment
There was a problem hiding this comment.
LGTM, but would appreciate a +1 from another if possible.
Member
Author
|
Merging, considering no other reviewers and tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
As Ubuntu 16.04 support is deprecated, switch to Ubuntu 18.04.
The PR also includes Virtualbox guest addition changes to make them work in U18.