Conversation
nzlosh
approved these changes
Sep 16, 2021
m4dcoder
requested changes
Sep 16, 2021
Collaborator
There was a problem hiding this comment.
- Do we need to update the Jinja version to >= 2.11 in requirements.txt?
- Can you also update description of this PR on why we are using sandboxed environment
- Please add a changelog entry.
- The CI weren't building because workflows was automatically disabled by Github due to inactivity. I believe there's a build failure that need to be fixed.ding because workflows was automatically disabled by Github due to inactivity. It's resolved now. But I believe there's an unrelated build failure that need to be fixed.
Contributor
Author
@m4dcoder Addressed your review comments (stealing the sphinx change from your PR!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Jinja sandboxed environment, so that any templates that attempt to access insecure code will be rejected.