Fix schema of with items task to not allow additional properties#195
Merged
Fix schema of with items task to not allow additional properties#195
Conversation
Users can accidentally indent the action under the with statement. Fix the JSON schema for the with items task to not allow additional properties. Inspection of the workflow definition will throw a syntax exception.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 41 41
Lines 2728 2728
Branches 540 540
=======================================
Hits 2565 2565
Misses 100 100
Partials 63 63
Continue to review full report at Codecov.
|
Normal task is allowed to leave action property empty to perform action less task transition. With items task should not leave the action property empty since it will just consume unnecessary system resources to iterate thru the items list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can accidentally indent the action under the with statement. Fix the JSON schema for the with items task to not allow additional properties. Inspection of the workflow definition will throw a syntax exception. Fixes #184.