Skip to content

Mongo 4.0 support for ansible - addressing issue #264#266

Merged
arm4b merged 6 commits intoStackStorm:masterfrom
amanda11:mongo_36
Jun 29, 2020
Merged

Mongo 4.0 support for ansible - addressing issue #264#266
arm4b merged 6 commits intoStackStorm:masterfrom
amanda11:mongo_36

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jun 26, 2020

Initial changes for 4.0. Having issues with local server, so getting a travis run performed to see if any obvious problems.
Will change out of draft once done more verification locally.

Closes #264

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jun 26, 2020
@amanda11 amanda11 marked this pull request as draft June 26, 2020 12:46
@amanda11 amanda11 changed the title [WIP] Mongo 3.6 support for ansible - addressing issue #264 Mongo 3.6 support for ansible - addressing issue #264 Jun 29, 2020
@amanda11 amanda11 marked this pull request as ready for review June 29, 2020 11:05
@amanda11
Copy link
Contributor Author

Local testing passed - performed testing with default versions and also overriding version using the mongodb_version parameter. Ready for review.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update:

Based on discussion in #development team decided to use MongoDB 4.0 across all the platforms.
Turns out previously Mongo 4 wasn't supported for EL7 and U16.

Now Mongo 4.0 is available for both platforms and we'd like to use this opportunity to rely on a single version consistently:
https://docs.mongodb.com/v4.0/tutorial/install-mongodb-on-ubuntu/#platform-support
https://docs.mongodb.com/v4.0/tutorial/install-mongodb-on-red-hat/#platform-support

Less code hacks in installers and it will simplify things by a lot!

@amanda11
Copy link
Contributor Author

Based on discussion in #development team decided to use MongoDB 4.0 across all the platforms.
Turns out previously Mongo 4 wasn't supported for EL7 and U16.

Now Mongo 4.0 is available for both platforms:
https://docs.mongodb.com/v4.0/tutorial/install-mongodb-on-ubuntu/#platform-support
https://docs.mongodb.com/v4.0/tutorial/install-mongodb-on-red-hat/#platform-support

This will guarantee consistency in Mongo version everywhere. Less code hacks in installers and will simplify things by a lot!

I'll update to use version 4.0 - will mark it as draft again...

@amanda11 amanda11 marked this pull request as draft June 29, 2020 11:29
@amanda11 amanda11 changed the title Mongo 3.6 support for ansible - addressing issue #264 Mongo 4.0 support for ansible - addressing issue #264 Jun 29, 2020
@amanda11
Copy link
Contributor Author

amanda11 commented Jun 29, 2020

NB. This can be simplified if we remove the redhat 6 support under the same PR. We could then go to having a single default which is the 4.0. OR we could leave it as per this PR which allows you to easily have different defaults per O/S - if we think we will go to different versions in near future on different O/S.
Actually can simplify now - as mongodb4.0 is listed as supported on RH 6. Next commit will have 4.0 as default for all.

Another consideration is whether we want to leave all the apt-keys for the different mongo versions, if we want to allow users to choose another version of mongodb if they need to. I have left in, as makes easier for Ubuntu installs - and we previously had them in for older versions like 3.2.

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Jun 29, 2020
@amanda11 amanda11 marked this pull request as ready for review June 29, 2020 13:13
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For EL7 and U16, Install Mongo 4.0 (Ansible)

2 participants