Support SMISMEMBER#2077
Merged
NickCraver merged 15 commits intoStackExchange:mainfrom Apr 12, 2022
Avital-Fine:SetContains
Merged
Support SMISMEMBER#2077NickCraver merged 15 commits intoStackExchange:mainfrom Avital-Fine:SetContains
NickCraver merged 15 commits intoStackExchange:mainfrom
Avital-Fine:SetContains
Conversation
NickCraver
requested changes
Apr 10, 2022
Collaborator
NickCraver
left a comment
There was a problem hiding this comment.
Spotted a few things cross-PR in reviewing these, notes inline! Thanks again, these PRs are fantastic and you're cranking 'em out <3
Comment on lines
+1111
to
+1114
| /// <returns> | ||
| /// <see langword="true"/> if the element is a member of the set. | ||
| /// <see langword="false"/> if the element is not a member of the set, or if key does not exist. | ||
| /// </returns> |
Collaborator
There was a problem hiding this comment.
In this case doc should say an array of these true/false, matching position, e.g.
Suggested change
| /// <returns> | |
| /// <see langword="true"/> if the element is a member of the set. | |
| /// <see langword="false"/> if the element is not a member of the set, or if key does not exist. | |
| /// </returns> | |
| /// <returns> | |
| /// An array of booleans corresponding to <paramref name="values"/>, for each: | |
| /// <see langword="true"/> if the element is a member of the set. | |
| /// <see langword="false"/> if the element is not a member of the set, or if key does not exist. | |
| /// </returns> |
What happens when the key isn't present, all falses?
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
NickCraver
reviewed
Apr 11, 2022
NickCraver
approved these changes
Apr 12, 2022
Collaborator
NickCraver
left a comment
There was a problem hiding this comment.
Looking good - thank you for this!
Collaborator
|
Pushed one last tidy on the tests, we should nuke the key when starting to ensure a consistent test run - after that clears will merge in. |
Contributor
Author
Right 😅 |
added 2 commits
April 12, 2022 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redis-stack.io/commands/smismember/
#2055