Merged
Conversation
3 tasks
Collaborator
Author
|
@rkarthick I really just want a second set of eyes on this, if you have time to review happy to get it in and unblock ya! |
rkarthick
approved these changes
Feb 10, 2022
Contributor
rkarthick
left a comment
There was a problem hiding this comment.
LGTM.
Do we need to modify this:
to
if (!serverType.SupportsAutoConfigure())
Collaborator
Author
|
@rkarthick Indeed! Missed a file in the branch do-over here, thanks! |
Collaborator
Author
|
@rkarthick thanks again for taking a poke here and helping us improve - a PR against |
Contributor
|
this is great, ty @NickCraver I will open a new PR over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make PRs like #1977 and #1425 much easier.