Add integration points for ConfigurationOptions customizers#1809
Merged
NickCraver merged 8 commits intoStackExchange:mainfrom Jul 26, 2021
philon-msft:main
Merged
Add integration points for ConfigurationOptions customizers#1809NickCraver merged 8 commits intoStackExchange:mainfrom philon-msft:main
NickCraver merged 8 commits intoStackExchange:mainfrom
philon-msft:main
Conversation
Prefix each entry with a timestamp that looks like: 2021-07-01T18:18:47.9263352Z: cachename.redis.cache.windows.net:6380/Interactive: Connecting... 2021-07-01T18:18:47.9463333Z: cachename.redis.cache.windows.net:6380: BeginConnectAsync 2021-07-01T18:18:47.9483351Z: 1 unique nodes specified
This also shortens the format to HH:mm:ss.ffff, which is all we need for debugging and it's less to grok. Also prevents double timestamp logging in tests.
added 2 commits
July 25, 2021 16:12
Also re-arranges `ConnectAsync` to be under the overloads like `Connect`. I don't think we want `null` to go boom here - no real win case for the user, so let's just make it handle null with no fuss.
mgravell
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the use of extensions that customize ConfigurationOptions settings to tune behavior or add new capabilities. As proposed in #1801
Adds: