Fix sentinel default port when connecting with configuration string#1525
Merged
NickCraver merged 4 commits intoStackExchange:mainfrom Aug 26, 2020
Merged
Fix sentinel default port when connecting with configuration string#1525NickCraver merged 4 commits intoStackExchange:mainfrom
NickCraver merged 4 commits intoStackExchange:mainfrom
Conversation
|
@mgravell Any chance we can get this reviewed and merged? |
Contributor
Author
|
@NickCraver @mgravell looks like you are getting ready to do another release. Think we can this small change merged? :-) |
NickCraver
approved these changes
Aug 26, 2020
Collaborator
NickCraver
left a comment
There was a problem hiding this comment.
Pushed a few tweaks but looking good - thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that when using a configuration string to connect that we only parse the configuration string and not set any defaults on it until it is forwarded on to the connect methods that take
ConfigurationOptions