Centralized package versioning with Directory.Packages.props#1421
Centralized package versioning with Directory.Packages.props#1421NickCraver merged 2 commits intomasterfrom
Conversation
Explicitly didn't do /toys here because the versions aren't shared but if it makes sense: yeah let's add em. This structure is made for easier migration to https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions later (we should just need to remove the manual import.
|
In your tests folder, there is already a file If I add the
This also build fine and single place too! (I already removed the individual imports for Directory.Packages.props in every .csproj first) |
mgravell
left a comment
There was a problem hiding this comment.
I like it; library updates are currently uber painful due to conditional imports etc; this will be great; I'm 👍 for "implement it with the hack now, clean up when the better fix lands" - same approach I used with the deterministic builds, which will benefit from cleanup when 3.1.300 lands
|
@schemburkar Thanks for the eyes here, obvious fail after seeing it - much appreciated! Simplifying this further. |
Explicitly didn't do
/toyshere because the versions aren't shared but if it makes sense: yeah let's add em. This structure is made for easier migration to https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions later (we should just need to remove the manual import in each project file (necessary for ordering):If you're wondering why
Directory.Build.targetsdoesn't work - I'm not sure. It's fine fornetcoreapp*builds, but .NET Full framework throws a fit:...but the approach in this PR is both works and is closer to future plans.