Skip to content

NRediSearch Test Suite Fixes#1383

Merged
NickCraver merged 1 commit intomasterfrom
craver/test-fixing
Mar 14, 2020
Merged

NRediSearch Test Suite Fixes#1383
NickCraver merged 1 commit intomasterfrom
craver/test-fixing

Conversation

@NickCraver
Copy link
Copy Markdown
Collaborator

@NickCraver NickCraver commented Mar 14, 2020 •
edited
Loading

NRediSearch

  • Updated module so we're testing the right thing
  • More output in the logging path for diagnosing issues
  • Remove all the FLUSHDB calls masking issues
  • Handle duplicate documents in latest module

Note: locally (on WSL 2), this fixes some issues and introduces stability but does not fix 2 scoring issues. Suggestions are coming back with scores > 1.0, which by the documentation is not supposed to happen...so I'm not sure what should be happening here. Here's the local WSL fail:

 NRediSearch.Test.ClientTests.ClientTest.TestGetSuggestionWithScore:
  Message: 
    StackExchange.Redis.RedisCommandException : Missing required fields:  score not within range: 2.11660146713257
  Stack Trace: 
    SuggestionBuilder.Build() line 99
    Client.GetSuggestionsWithPayloadAndScores(RedisResult[] results) line 1271
    Client.GetSuggestions(String prefix, SuggestionOptions options) line 796
    ClientTest.TestGetSuggestionWithScore() line 701

NRediSearch.Test.ClientTests.ClientTest.TestAddSuggestionGetSuggestionPayloadScores:
  Message: 
    StackExchange.Redis.RedisCommandException : Missing required fields:  score not within range: 2.71068739891052
  Stack Trace: 
    SuggestionBuilder.Build() line 99
    Client.GetSuggestionsWithPayloadAndScores(RedisResult[] results) line 1271
    Client.GetSuggestions(String prefix, SuggestionOptions options) line 796
    ClientTest.TestAddSuggestionGetSuggestionPayloadScores() line 642

However, the current fixes tidy up the CI pipeline so I recommend merging this as-is, then I'll keep follow-ing up with various local errors and I'm looking at some Docker test options as alternatives to WSL2 so that people can run either.

NRediSearch fixes
f98a73b 
- Updated module so we're testing the right thing
- More output in the logging path for diagnosing issues
- Remove all the FLUSHDB calls masking issues
- Handle duplicate documents in latest module

Note: this fixes some issues and introduces stability but *does not* fix 2 scoring issues. Suggestions are coming back with scores > 1.0, which by the documentation is not supposed to happen...so I'm not sure what should be happening here. Pushing up to get more eyes.
@NickCraver NickCraver changed the title WIP: Test Suite Fixes NRediSearch Test Suite Fixes Mar 14, 2020
@NickCraver NickCraver marked this pull request as ready for review March 14, 2020 00:14
@NickCraver NickCraver requested a review from mgravell March 14, 2020 00:18
@NickCraver
Copy link
Copy Markdown
Collaborator Author

NickCraver commented Mar 14, 2020

Hmmm CI is all happy - going to get this merged in and the other failing PRs updated so we get a proper CI going.

@NickCraver NickCraver merged commit 084c9c1 into master Mar 14, 2020
@NickCraver NickCraver deleted the craver/test-fixing branch March 14, 2020 00:23
@NickCraver NickCraver mentioned this pull request Mar 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgravell mgravell Awaiting requested review from mgravell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NickCraver