Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.8.24
Choose a base ref
...
head repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.8.31
Choose a head ref
  • 7 commits
  • 6 files changed
  • 4 contributors

Commits on Dec 18, 2024

  1. Configuration menu
    Copy the full SHA
    1a4c66d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2025

  1. Improve readme - what even is this? (#2837)

    * Improve readme - what even is this?
    
    Propose words for #2836
    
    * Update README.md
    
    ---------
    
    Co-authored-by: Nick Craver <nrcraver@gmail.com>
    mgravell and NickCraver authored Feb 18, 2025
    Configuration menu
    Copy the full SHA
    fe04b9a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. Configuration menu
    Copy the full SHA
    3bd3e66 View commit details
    Browse the repository at this point in the history
  2. Fix: Respect IReconnectRetryPolicy in disconnect loops (#2853)

    Fixes the case where we loop from `Connecting` -> `BeginConnectAsync` -> `OnDisconnected` and the next heartbeat triggers a reconnect again due to the backoff thresholds resetting. This ultimately causes the backoff to not be respected.
    
    Here, we're doing 2 things:
    - Upping the max exponential backoff window to 60 seconds which better handlers clients at scale and mass DDoS cases.
    - Only resets the reconnect counter on the first disconnect, not doing so again until we've successfully reconnected and heartbeated again, so backoffs are properly respected.
    NickCraver authored Mar 4, 2025
    Configuration menu
    Copy the full SHA
    437e1ff View commit details
    Browse the repository at this point in the history
  3. Update release notes

    NickCraver committed Mar 4, 2025
    Configuration menu
    Copy the full SHA
    2a47eb5 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2025

  1. Fix: Rexpect backoff in the disconnect -> resurrection case as well (#…

    …2856)
    
    Additional case handling for #2853, respecting backoff in the disconnected -> resurrecting state case. We need to check backoff in that flow as well to prevent a premature `TryConnect`.
    NickCraver authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    50f2218 View commit details
    Browse the repository at this point in the history
  2. Physical bridge: handle the reconnect count case

    Without this, we don't increase the current count and don't escalate in the exponential retry case, so let's both do that and log that something is happening so we can diagnose from the logs.
    NickCraver committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    cd7a3b2 View commit details
    Browse the repository at this point in the history
Loading