Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.7.27
Choose a base ref
...
head repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.7.33
Choose a head ref
  • 6 commits
  • 18 files changed
  • 3 contributors

Commits on Mar 1, 2024

  1. release notes

    mgravell committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ae72fb7 View commit details
    Browse the repository at this point in the history
  2. new tunnel-based RESP logging and validation (#2660)

    * Provide new LoggingTunnel API; this
    
    * words
    
    * fix PR number
    
    * fix file location
    
    * save the sln
    
    * identify smessage as out-of-band
    
    * add .ForAwait() throughout LoggingTunnel
    
    * clarify meaning of path parameter
    mgravell authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    9ab79e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Normalize release notes

    NickCraver committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    441f89a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    91520e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. CheckTrustedIssuer: Fixes for invalid chains (#2665)

    This issue was brought to my attention last night (thanks to Badrish Chandramouli): dotnet/dotnet-api-docs#6660
    
    This changeset ensures that we do not honor self-signed certs or partial/broken chains as a result of `X509VerificationFlags.AllowUnknownCertificateAuthority` downstream and adds a few tests and utilities to generate test certificates (currently valid for ~9000 days). Instead we are checking that the certificate we're being told to trust is explicitly in the chain, given that the result of `.Build()` cannot be trusted for this case.
    
    This also resolves an issue where `TrustIssuer` could be called but we'd error when _no errors_ were detected (due to requiring chain errors in our validator), this means users couldn't temporarily trust a cert while getting it installed on the machine for instance and migrating between the 2 setups was difficult.
    
    This needs careful eyes, please scrutinize heavily. It's possible this breaks an existing user, but...it should be broken if so unless there's a case I'm not seeing.
    NickCraver authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    baf2b1e View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Fix #2664 Backlog: move to full synchronous behavior since we're on a…

    … dedicated thread (#2667)
    
    Resolving #2664.
    
    This went through a few iterations early on, but in the current form the issue is that we can await hop to a thread pool thread and have our wait blocking there - not awesome. We want to avoid that entirely and do a full sync path here.
    NickCraver authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4da3d62 View commit details
    Browse the repository at this point in the history
Loading