test: post state transitions with deliverImmediately and assert after termination#321
Merged
Merged
Conversation
… termination The state-transition tests observe SQRLUpdaterState changes via NSDistributedNotificationCenter from the launched TestApplication. The posts used the default-coalescing form, so the final AwaitingRelaunch notification — posted right before the app calls relaunchToInstallUpdate and exits — could sit in the per-process queue and be discarded at termination. Post with deliverImmediately:YES so each transition is handed to notifyd synchronously, and reorder the tests to wait for testApplication.terminated first. Once the app has exited every notification has been posted; the states assertion then only needs to allow for in-flight delivery rather than racing the entire download/verify/stage pipeline. Also adds the missing withTimeout to the no-update variant, which was still on Nimble's 1s default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
statedescribe block observesSQRLUpdaterStatechanges viaNSDistributedNotificationCenterfrom the launchedTestApplication. The posts used the default-coalescing form (postNotificationName:object:userInfo:), so the finalAwaitingRelaunchnotification — posted right before the app callsrelaunchToInstallUpdateand exits — can sit in the per-process queue and be discarded at termination. Seen onmacOS 14 arm64as:Root-cause fix: post with
deliverImmediately:YESso each transition is handed tonotifydsynchronously.Ordering fix: wait for
testApplication.terminatedfirst, then assert onstates. Once the app has exited, every notification has been posted; the assertion only needs to allow for in-flight delivery fromnotifyd, not race the entire download → verify → stage pipeline against a wall clock.Also adds the missing
withTimeout(SQRLLongTimeout)to the no-update variant, which was still on Nimble's 1s default.