fix: invert isVersionStandard superset check so numeric versions pass#314
Merged
Conversation
isVersionStandard was OR'ing the result of [decimalDigits isSupersetOfSet:partChars]
into versionBad without negation, so an all-digit part marked the version as bad.
Any app with ElectronSquirrelPreventDowngrades=YES would fail every update at the
'is not a valid version string' check for normal versions like '1.2.3', making the
downgrade comparison unreachable.
Also reject empty parts ('1..3') since the empty set is trivially a subset of digits.
Adds direct unit coverage for isVersionStandard — previously only
isVersionAllowedForUpdate:from: was tested.
1f08091 to
a59c6f6
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isVersionStandardwas OR'ing the result of[decimalDigits isSupersetOfSet:partChars]intoversionBadwithout negation — so an all-digit part marked the version as bad.isVersionStandard(@"1.2.3")returnedNO;isVersionStandard(@"a.b.c")returnedYES.Effect: any app with
ElectronSquirrelPreventDowngradesenabled fails every update at the'is not a valid version string'check for normal versions, never reaching the actual downgrade comparison.This went unnoticed because the existing tests only cover
+isVersionAllowedForUpdate:from:(the comparison), not the format gate in front of it.Also rejects empty parts (
"1..3") — the empty set is trivially a subset of digits, so it would otherwise slip through after the negation fix.Adds direct unit coverage for
isVersionStandard.