New group rounded feature and small color fix control themes#49
New group rounded feature and small color fix control themes#49Spiderpig86 merged 5 commits intoSpiderpig86:masterfrom FlorianWoelki:master
Conversation
Spiderpig86
left a comment
There was a problem hiding this comment.
Overall, thanks for the new addition of the tags. I see you're hard at work on adding some new things which are welcome. Please address the comments and I'll review again.
| border-radius: 0; | ||
| &.group-tags { | ||
| /* Round first and last tag in the grouped tags */ | ||
| &.group-rounded { |
There was a problem hiding this comment.
To try to stick to BEM naming conventions moving forward, we should name this group-tags--rounded.
| } | ||
|
|
||
| &:last-child { | ||
| border-radius: 0 290486px 290486px 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 290486px 290486px 0
| // Round first and last tag in the grouped tags | ||
| &--rounded .tag { | ||
| &:first-child { | ||
| border-radius: 290486px 0 0 290486px; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 290486px 0 0 290486px
| } | ||
|
|
||
| &:last-child { | ||
| border-radius: 0 0.25rem 0.25rem 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 0.25rem 0.25rem 0
| &:not(:first-child):not(:last-child) { | ||
| border-radius: 0; | ||
| &:first-child { | ||
| border-radius: 0.25rem 0 0 0.25rem; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0.25rem 0 0 0.25rem
| &.group-tags { | ||
| .tag, | ||
| &--rounded .tag { | ||
| margin-right: 0 !important; |
| /* Used for grouping tags together */ | ||
| &.group-tags .tag { | ||
| margin-right: 0 !important; | ||
| &.group-tags { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Description
Sorry for so much PR's :D
I've added a common use case for actual rounding group tags. I think it should be pretty useful for some use cases. Furthermore, there are rounded tags so why not having grouped rounded tags ;)
In addition, I've added the primary color to the control themes. This fix resolved that primary colored closing tags are not clickable.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
You can see the result of the new rounded grouping tags in the image below:
