Fix margin top for input field in combination with icon, label and input-control#47
Merged
Spiderpig86 merged 2 commits intoSpiderpig86:masterfrom Nov 10, 2020
FlorianWoelki:master
Merged
Fix margin top for input field in combination with icon, label and input-control#47Spiderpig86 merged 2 commits intoSpiderpig86:masterfrom FlorianWoelki:master
Spiderpig86 merged 2 commits intoSpiderpig86:masterfrom
FlorianWoelki:master
Conversation
- Fixed a minor issue: whenever using a icon and label with input-control there was a not good looking margin-top
Owner
|
🙌 Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an issue when putting an icon and label in combination with an input field. Because of the input-control class there will be a not good looking margin between the label and the input field. I've fixed this by adding a margin-top 0 whenever there is a label above the input-control class.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This has been tested by creating a input field with a icon and a label:
Current behaviour:

Expected behaviour:
