fix: vertically centering loading spinner in the animated class#167
Closed
bjorndonald wants to merge 1 commit intoSpiderpig86:masterfrom
Closed
fix: vertically centering loading spinner in the animated class#167bjorndonald wants to merge 1 commit intoSpiderpig86:masterfrom
bjorndonald wants to merge 1 commit intoSpiderpig86:masterfrom
Conversation
Owner
|
Thanks for creating a PR! I have taken a look and left a comment. |
Spiderpig86
requested changes
Jun 21, 2023
| width: 1rem; | ||
| left: calc(50% - (1em / 1.25)); | ||
| top: calc(50% - (1em / 1.35)); | ||
| top: calc(50% - ((1rem + 2px) / 2)); |
Owner
There was a problem hiding this comment.
Let's remove the 2px and change it to (1rem / 2). I tried it with 0px which looks to be closer to the center and we can avoid adding more magic numbers to the framework.
Contributor
Author
There was a problem hiding this comment.
Alright that works
Owner
|
Closing. Moved to #242 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the loading spinner is not fully vertically centered. So I made a single line adjustment to the animation.scss. And changed the means of calculating the top property.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Test Configuration:
Checklist: