Skip to content

Update imnodes bindings to latest version & fix getNode___SpacePos bindings #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SpaiR merged 3 commits into from
Oct 21, 2024
Merged

Update imnodes bindings to latest version & fix getNode___SpacePos bindings #282

SpaiR merged 3 commits into from
Oct 21, 2024

Conversation

@serivesmejia
Copy link
Contributor

@serivesmejia serivesmejia commented Sep 30, 2024

Pulls latest commit of imnodes which includes new function SnapNodeToGrid, generates ast & api, fixes getNode___SpacePos functions to actually return ImVec2

(sigh... finally got this right using WSL)

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@serivesmejia
Copy link
Contributor Author

serivesmejia commented Oct 6, 2024

Also addresses #193 from a while back...

@SpaiR SpaiR added the feat New feature or request label Oct 8, 2024
@SpaiR
Copy link
Owner

SpaiR commented Oct 8, 2024

Looks much better. But can you also address those changes?

image

Methods now accept ImNodesStyle class. You just need to add an optional argument to them. You can do it in the same way it's done here:

imgui-java/imgui-binding/src/main/java/imgui/ImGui.java

Lines 288 to 304 in c776b1b

/**
* New, recommended style (default)
*/
@BindingMethod
public static native void StyleColorsDark(@OptArg ImGuiStyle style);
/**
* Best used with borders and a custom, thicker font
*/
@BindingMethod
public static native void StyleColorsLight(@OptArg ImGuiStyle style);
/**
* Classic imgui style
*/
@BindingMethod
public static native void StyleColorsClassic(@OptArg ImGuiStyle style);

@SpaiR SpaiR linked an issue Oct 8, 2024 that may be closed by this pull request
Update ImNodes to latest version #193
Closed
@serivesmejia
Copy link
Contributor Author

serivesmejia commented Oct 8, 2024

Hopefully that should do it

@serivesmejia
Copy link
Contributor Author

serivesmejia commented Oct 14, 2024 •
edited
Loading

is there an eta on when this might be released?

@SpaiR
Copy link
Owner

SpaiR commented Oct 15, 2024

is there an eta on when this might be released?

Not anytime soon.

@SpaiR SpaiR linked an issue Oct 21, 2024 that may be closed by this pull request
Missing Bindings / Incorrect return types #290
Closed
@SpaiR SpaiR merged commit 7be2a29 into SpaiR:main Oct 21, 2024
@serivesmejia
Copy link
Contributor Author

serivesmejia commented Oct 31, 2024

Thank you so much😅 it is such a relief to finally get rid of all those // TODO, and also being able to see stacktraces for imnodes assertion errors... This will make my life so much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feat New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Bindings / Incorrect return types Update ImNodes to latest version

2 participants

@serivesmejia @SpaiR