Go to Definition support and Code Editor Preference#348
Merged
SpaiR merged 8 commits intoSpaiR:mainfrom May 3, 2025
Merged
Conversation
(I still wish I could figure out how to get it to breakpoint but oh well)
(There's a linter for that??)
|
Thanks for doing this Drulikar/Spair, this was always one of the things holding me back from SDMM. |
|
Awesome. This would be incredibly useful. |
SpaiR
requested changes
May 1, 2025
Owner
SpaiR
left a comment
There was a problem hiding this comment.
Apologies for the delayed review on my side. Overall, the code looks great, and I really like the feature! There are just a couple of minor changes that could slightly improve the code quality. Other than that, everything looks awesome. 👍👍👍
SpaiR
approved these changes
May 3, 2025
Contributor
Author
|
In release mode (not dev) vscode's (not npp nor dreammaker) exec command seems to to temporarily open a command prompt window. Not sure how to address that. But seems to be because code uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows you to right click prefabs and go to the file (and line/col if supported) in your currently selected code editor from preferences. When StrongDMM launches, it ensures your loaded preference appears in path, otherwise it tries to reset the config to something that will work (tries VSC -> Dreammaker -> NPP -> Default).
I also set a workspace config to allow the rustanalyzer to read the sdmmparser project (though I could not get breakpoints working).
Supported code editors:
SpaiR did a bulk of the work getting location information from the parser. Let me know if any these changes appear redundant/problematic or if you want functions called in other files (though let me know how I would pass it down).
Type of change