Skip to content

Fixes filter() not taking name as a kwarg#436

Merged
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
Zonespace27:filter()-name-fix
Jul 12, 2025
Merged

Fixes filter() not taking name as a kwarg#436
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
Zonespace27:filter()-name-fix

Conversation

@Zonespace27
Copy link
Copy Markdown
Contributor

@Zonespace27 Zonespace27 commented Jul 11, 2025 •
edited by SpaceManiac
Loading

This fixes an issue where the "name" kwarg was erroring (see screenshot) when filter() was called, despite being valid & correct DM.

Fixes #430.

@SpaceManiac
Copy link
Copy Markdown
Owner

SpaceManiac commented Jul 12, 2025

You can modify this line to make the name argument acceptable for all filters, instead of having to add it to each filter separately:

SpacemanDMM/crates/dreamchecker/src/lib.rs

Line 2465 in 5a96f6b

if *arg != "type" && !arglist.contains(arg) {

@Zonespace27
Copy link
Copy Markdown
Contributor Author

Zonespace27 commented Jul 12, 2025

You can modify this line to make the name argument acceptable for all filters, instead of having to add it to each filter separately:

SpacemanDMM/crates/dreamchecker/src/lib.rs

Line 2465 in 5a96f6b

if *arg != "type" && !arglist.contains(arg) {

Done

@SpaceManiac SpaceManiac merged commit e2c596a into SpaceManiac:master Jul 12, 2025
1 check passed
@SpaceManiac SpaceManiac added this to the suite v1.11 milestone Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

suite v1.11

Development

Successfully merging this pull request may close these issues.

Dreamchecker flags "name" parameter in filter() as invalid

3 participants

@Zonespace27 @SpaceManiac @johndoe2013