Change the hasher used for HashMap/Sets#414
Merged
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom Nov 9, 2024
Merged
Conversation
SpaceManiac
approved these changes
Nov 9, 2024
Owner
SpaceManiac
left a comment
There was a problem hiding this comment.
Also seeing a clear 7-9% speedup on a couple of machines. Binary size is not increased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose to use foldhash since we're not needing cryptographically secure hashing, nor are we concerned with people reverse-engineering application state.
Basically just changing the RandomState or the HashMap/Set import everywhere. The *Ext types provide the
::new()interface.Tested dm-langserver, all works well:
