fix preprocessor relative filepath evaluation for fexists#401
Merged
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom Jul 16, 2024
Merged
fix preprocessor relative filepath evaluation for fexists#401SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
Conversation
ZeWaka
commented
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way I implemented const-eval'd fexists is slightly incorrect.
It's evaulating the existence of the path relative to the invocation of the library or something, instead of relative to the
dmecurrent file.This is causing errors in StrongDMM, because it's checking paths relative to the application exe file.
I tested by building StrongDMM and using this fixed version, and it worked correctly.