Implements /proc/final, piped into should not override#369
Merged
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom Oct 18, 2023
Merged
Implements /proc/final, piped into should not override#369SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
Conversation
As a part of this we need to make a struct when building proc defs, to keep track of their flags AND their kind at the same time. We then pass that down into a new flags var on the proc decl struct, and we're golden Only thing of note is I removed the is_private and is_protected vars from proc declerations because they were totally unused. Spooky added em a long time ago and I think it was for not much reason
Contributor
Author
|
Fixing proc return types, please hold |
fb26854 to
379b2c9
Compare
Contributor
Author
|
Moved the as syntax stuff to #370, this is all clear |
379b2c9 to
6076b1d
Compare
1497720 to
2e5ef25
Compare
Contributor
Author
|
sorry accidentally killed your commit, it's still built in tho. had trouble with two different locals and forgot which had most recent changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of this we need to make a struct when building proc defs, to keep track of their flags AND their kind at the same time.
We then pass that down into a new flags var on the proc decl struct, and we're golden
Only thing of note is I removed the is_private and is_protected vars from proc declerations because they were totally unused. Spooky added em a long time ago and I think it was for not much reason