Implements __IMPLIED_TYPE__#368
Merged
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom Oct 17, 2023
Merged
Conversation
It turns out this kinda sucks. it doesn't work with ::, so we don't even really need to care about its value. I threw in support for constant eval but that's inconsistent on our end cause type_hint doesn't always play. I figure it's good to at least have something, and issues can get sorted out as we go
…nto implied-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out this kinda sucks. it doesn't work with ::, so we don't even really need to care about its value.
I threw in support for constant eval but that's inconsistent on our end cause type_hint doesn't always play. I figure it's good to at least have something, and issues can get sorted out as we go.
It is also seemingly massively annoying to eval in like, an istype(), since it has special case behavior there. I just kinda left it sit since I'm pretty sure it'd be a massive change to support and it like does not matter