Fix Sleep/Purity checks being skipped under certain overrides#311
Merged
spookydonut merged 3 commits intoSpaceManiac:masterfrom Apr 15, 2022
Merged
Fix Sleep/Purity checks being skipped under certain overrides#311spookydonut merged 3 commits intoSpaceManiac:masterfrom
spookydonut merged 3 commits intoSpaceManiac:masterfrom
Conversation
…ty when overrides are present
Collaborator
|
@fira I'd like to see a test case written for this that proves it works and will fail if your changes are removed. |
Contributor
Author
there is a snippet in the issue but let me add a test proper then too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue PR for #267 and as discuted on coderbus ages ago back then
TL;DR is, there being an override one way or another shouldn't prevent you from checking children too
Discovered on CM-SS13 as we had a controller held up by sleep randomly in production, and no amount of hammering SHOULD_NOT_SLEEP checks seemed to trip anything !
As additional and separate note, and as we discussed back then on coderbus, there are more situations with assumptions of types that mean SpacemanDMM will miss out on a big part of the violators. It's actually for best, because "properly" checking is near impossible on SS13 due to double dispatch constructs just about erasing the "actual" types. This resulted in about 25,000 violating procs when fixing it for CM-SS13, for example...