use indexmap instead of linked hashmap, switch hasher to use ahash#293
Merged
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom Nov 17, 2021
Merged
use indexmap instead of linked hashmap, switch hasher to use ahash#293SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
Conversation
Owner
|
I saw a much smaller speedup on my machine, over several trials: dreamchecker average time from 5.946s to 5.794s, dm-langserver average time from 6.488s to 6.344s. Not nothing, but not as drastic as you reported. Can you try doing a few extra trials so we can find out if it your numbers were a fluke (disk cache can be a big confounder), or if there's a difference between our machines? |
Contributor
Author
|
might be because your machine just doesn’t support AES-NI like most modern machines do. have you tried on larger codebases where the extra seconds matter more |
Owner
|
As far as I can tell my processor does support AES-NI. I was testing on /tg/station. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ahash is straight up faster for string hashing
indexmap is at least maintained and has methods that we use, also faster iteration.
before:
after: