support for L?[x] list access syntax#262
Merged
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom Apr 22, 2021
sohpeach:safeindex
Merged
support for L?[x] list access syntax#262SpaceManiac merged 2 commits intoSpaceManiac:masterfrom sohpeach:safeindex
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom
sohpeach:safeindex
Conversation
Owner
|
The BYOND forum link in your comment is broken, do you have another reference? |
SpaceManiac
approved these changes
Apr 22, 2021
Contributor
Author
|
It was a bug report showing how a bunch of stuff compiled incorrectly in the current stable/beta branches. Lummox is still changing It was merged into a similar thread but I can't find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed the current
IndexKindenum toPropertyAccessKindpurely based off of the fact that somewhere in the byond ref both procs and vars are referred to as a datum's "properties" and I had no better name ideas.The checker treats conditional list accesses exactly the same as normal ones. I was going to add some linting stuff for them but their expected behaviour is completely up in the air at the moment (see http://www.byond.com/forum/post/2667247.)