Remove error if a proc has both should_not_sleep and set waitfor = 0#211
Remove error if a proc has both should_not_sleep and set waitfor = 0#211SpaceManiac merged 1 commit intoSpaceManiac:masterfrom
Conversation
…waitfor See tgstation/tgstation#53553 (comment) for why this logic is invalid.
|
There should be a different lint define for this case, rather than allowing set waitfor when people expect no sleeping. We are not the only people using this so we can't change the API contract like that. |
|
But set waitfor doesn't sleep! It just guarantees the caller will not be locked up, the same thing should_not_sleep tries, but fails to guarantee. the only time set waitfor = false would kick in, is in a sleep that And because byond is not a statically typed language, should_not_sleep can not catch every case where something can sleep, trying to is as mathematically impossible as the halting problem, you can get very close, but not perfect detection. It makes no sense to force disabling of set waitfor = false to use |
See tgstation/tgstation#53553 (comment) for why this logic is invalid.