Skip to content

Check child overrides when checking for pure/sleep violations#204

Closed
spookydonut wants to merge 2 commits intoSpaceManiac:masterfrom
spookydonut:sleeppureoverrides
Closed

Check child overrides when checking for pure/sleep violations#204
spookydonut wants to merge 2 commits intoSpaceManiac:masterfrom
spookydonut:sleeppureoverrides

Conversation

@spookydonut
Copy link
Copy Markdown
Collaborator

@spookydonut spookydonut commented Aug 12, 2020

Fixes #203

@SpaceManiac SpaceManiac changed the title Make dreamchecker check child overrides when checking for pure/sleep … Check child overrides when checking for pure/sleep violations Aug 12, 2020
Copy link
Copy Markdown
Owner

@SpaceManiac SpaceManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is far, far too slow to be practical. I got tired of waiting for /tg/ to check after about 20 minutes.

@spookydonut
Copy link
Copy Markdown
Collaborator Author

This implementation is far, far too slow to be practical. I got tired of waiting for /tg/ to check after about 20 minutes.

well fuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SHOULD_NOT_SLEEP does not check overrides of procs being called for sleeps

2 participants