Fix sleeping code under spawn() triggering SpacemanDMM_should_not_sleep#177
Merged
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom Jul 3, 2020
Merged
Fix sleeping code under spawn() triggering SpacemanDMM_should_not_sleep#177SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
SpaceManiac merged 4 commits intoSpaceManiac:masterfrom
Conversation
spookydonut
approved these changes
Apr 22, 2020
spookydonut
requested changes
Apr 22, 2020
Collaborator
spookydonut
left a comment
There was a problem hiding this comment.
Allowing spawns in should not sleep i feel defeats the purpose of the lint but making it a config option to disable this would be ok
SpaceManiac
approved these changes
Jul 3, 2020
Owner
SpaceManiac
left a comment
There was a problem hiding this comment.
I lean towards thinking of spawn as more of a addtimer type call that happens to be builtin - it doesn't put the current call stack on hold, so it's not "sleeping" for purposes of the lint. In that lens this seems OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175