Fix double rotation of macro circle/line center coordinates (#233)#3
Merged
rampageservices merged 1 commit intodevelopfrom Mar 6, 2026
Merged
Conversation
The rendering code (draw.c) applies cairo_rotate() before cairo_translate() for CIRCLE, LINE21, and LINE22 macro primitives, meaning the rotation parameter already rotates the center coordinates as part of the Cairo transformation. The image copy/transform code (gerb_image.c) was updating the rotation parameter AND calling gerbv_rotate_coord() on the center coordinates. When the exported file was re-loaded, the center was rotated twice: once by the pre-rotated coordinates, and again by cairo_rotate(). Remove the redundant gerbv_rotate_coord() calls for CIRCLE and LINE21/LINE22, matching the pattern already used by LINE20, POLYGON, MOIRE, and THERMAL — all of which correctly rely on the rotation parameter alone. Fixes gerbv#233
180c677 to
49d1676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gerbv_rotate_coord()calls for CIRCLE, LINE21, and LINE22 macro primitives ingerb_image.cgerbv_rotate_coord()was double-applying the rotationUpstream PR: gerbv#310
Fixes gerbv#233