Fixes misleading variable naming in PID header file#31
Merged
noahzemlin merged 1 commit intoSoonerRobotics:masterfrom Aug 18, 2022
Merged
Fixes misleading variable naming in PID header file#31noahzemlin merged 1 commit intoSoonerRobotics:masterfrom
noahzemlin merged 1 commit intoSoonerRobotics:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 8 -1
Lines 457 456 -1
=========================================
- Hits 457 456 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower and upper are no longer switched in the header file, which is much nicer. VS Code was telling me upper was the first argument which produced obviously wrong answers.