fix(issue-43): add permission checks, port detection, and cleanup scripts#55
Merged
Merged
Conversation
…ipts ### Changes **1. Permission Detection** - start.sh: Add admin check for Windows (Git Bash/MSYS2) - start.bat: Add admin check with user prompt - Show warning if not running as Administrator - Allow user to continue anyway **2. Port Conflict Detection** - start.sh: Check GATEWAY_PORT and LLM_PORT conflicts - start.bat: Check port conflicts with netstat - Show helpful messages when conflicts detected - Allow user to continue anyway **3. Cleanup Scripts** - cleanup.sh: New cleanup script for Linux/macOS - Level 1: Light cleanup (logs, PIDs) - Level 2: Deep cleanup (configs, tokens, backups) - cleanup.bat: New cleanup script for Windows - Same functionality as bash version - Interactive menu with 3 options ### Testing - Manual testing on both Windows and Linux - Port conflict detection tested - Permission check tested Fixes #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Problem
`start.bat` silently fails or provides poor user experience in the following scenarios:
1. No Admin Privilege Check
2. No Port Conflict Detection
3. No Sensitive File Cleanup
Solution
1. Permission Detection
2. Port Conflict Detection
3. Cleanup Scripts
Testing
Impact
Fixes #43