Add -asset flag to filter release assets by filename pattern#62
Merged
Songmu merged 1 commit intoSongmu:mainfrom Mar 5, 2026
Merged
Add -asset flag to filter release assets by filename pattern#62Songmu merged 1 commit intoSongmu:mainfrom
Songmu merged 1 commit intoSongmu:mainfrom
Conversation
When a release contains non-archive assets (e.g. .rpm, .deb) alongside .tar.gz/.zip, maltmill could pick the wrong file. The -asset flag accepts a regexp pattern to select which assets to consider. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds an -asset CLI flag to restrict which GitHub release assets are considered (by filename regexp), preventing selection of non-archive assets when updating/creating formulae.
Changes:
- Parse and propagate
-asset(regexp) throughmaltmillandnewcommand flows. - Filter release assets in
getDownloadsbased on the provided pattern. - Add unit tests for arg parsing and asset filtering; document the new flag in the README.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cli.go |
Adds -asset flag parsing/validation and forwards it to the new subcommand. |
cmd_maltmill.go |
Stores and passes the compiled asset regexp into formula processing. |
formula.go |
Plumbs the asset regexp into release asset selection during formula updates. |
cmd_new.go |
Extends getDownloads to filter assets by filename regexp and threads the option through new. |
cli_test.go |
Adds coverage ensuring -asset is parsed for both main and new flows. |
formula_test.go |
Adds coverage for getDownloads behavior with/without an asset filter. |
README.md |
Documents -asset usage and adds it to options tables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a release contains non-archive assets (e.g. .rpm, .deb) alongside .tar.gz/.zip, maltmill could pick the wrong file. The -asset flag accepts a regexp pattern to select which assets to consider.