Conversation
|
|
||
| var jsonResponse = new HttpResponse<RarbgResponse>(indexerResponse.HttpResponse); | ||
|
|
||
| if (jsonResponse.Resource.rate_limit == 1) |
There was a problem hiding this comment.
remove this for now. RarBG has a bug where rate_limit = 1 on almost every request
Ref - Prowlarr/Prowlarr#1277
Ref - Prowlarr/Prowlarr@5cc044a
|
would it be prudent to remove the defunct cloudflare /captcha logic and associated settings as well? Originally posted by @Taloth in #4821 (comment) |
| var jsonResponse = new HttpResponse<RarbgResponse>(indexerResponse.HttpResponse); | ||
|
|
||
| // TODO: Uncomment when RARBG doesn't return it for most valid requests | ||
| // if (jsonResponse.Resource.rate_limit == 1) |
There was a problem hiding this comment.
| // if (jsonResponse.Resource.rate_limit == 1) | |
| if (jsonResponse.Resource.rate_limit is 1 && jsonResponse.Resource.torrent_results == null) |
There was a problem hiding this comment.
uncomment & only throw if there are no results to workaround false positive
|
|
||
| if (jsonResponse.Resource.torrent_results == null) | ||
| { | ||
| if (jsonResponse.Resource.rate_limit == 1) |
There was a problem hiding this comment.
suggest skip handling jsonResponse.Resource.error_code == 5 above and handle here instead
5 indicates a rate limit
There was a problem hiding this comment.
I’m basing the changes on the GHI, if we need to make other changes later we can.
|
Based on comments / users with jackett's testing - it probably makes sense to comment out the the rate_limit = 1 handling and land this otherwise as is. |
|
FYI some prowlarr rework to catch the http error before it tries to parse so the html isn't tried to be parsed |
Sonarr doesn't seem to be affected by this, since it doesn't retry with a new token if the current one is expired. |
| case HttpStatusCode.TooManyRequests: | ||
| throw new RequestLimitReachedException("Indexer API limit reached", TimeSpan.FromMinutes(2)); | ||
| case (HttpStatusCode)520: | ||
| throw new RequestLimitReachedException("Indexer API returned unknown error", TimeSpan.FromMinutes(3)); |
There was a problem hiding this comment.
Nit: 520 is known - internal servers behind cloudflare are rate limited/overwhelmed
when rated limited web returns http code 444 to cloudflare which returns 520 on cloudflare , there is no way to send 429 to cloudflare without it breaking the request properly and retrying it
There was a problem hiding this comment.
Unless it throws a 520 for another reason…
|
When will this be released? |
Database Migration
NO
Description
Updates Rarbg to handle additional rate limit cases.
Todos
Issues Fixed or Closed by this PR